Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): the cli runner should be able to run requests with workspace id by correct order #8220

Merged
merged 9 commits into from
Dec 4, 2024
Merged

fix(cli): the cli runner should be able to run requests with workspace id by correct order #8220

merged 9 commits into from
Dec 4, 2024

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Dec 2, 2024 •
edited
Loading

Changes:

  • UI: only generate runner CLI command with workspace id, when requests order in runner is consistent with workspace requests order
  • CLI: run requests by manual sorting order, when no -i option has been set
  • UI: "run folder" should include all sub folders

Ref: INS-4760

@ihexxa ihexxa self-assigned this Dec 2, 2024
@ihexxa ihexxa changed the title fix(runner): should not generate command with workspace id when all request are selected fix(cli): should not generate command with workspace id when all request are selected Dec 2, 2024
@ihexxa ihexxa changed the title fix(cli): should not generate command with workspace id when all request are selected fix(cli): the cli runner should be able to run requests with workspace id by correct order Dec 2, 2024
@ihexxa ihexxa requested a review from a team December 2, 2024 08:23
@filfreire filfreire force-pushed the fix/runner/gen-ws-cmd branch from d5e2810 to a340629 Compare December 2, 2024 16:12
notjaywu
notjaywu reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@notjaywu notjaywu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment

packages/insomnia/src/ui/routes/runner.tsx Outdated Show resolved Hide resolved
@ihexxa @notjaywu
Update packages/insomnia/src/ui/routes/runner.tsx
a2fee60 
Co-authored-by: Jay Wu <130019718+notjaywu@users.noreply.github.com>
@ihexxa
Copy link
Contributor Author

ihexxa commented Dec 3, 2024

left a comment

It looks good to me and ideally index could be changedItemIndex.

notjaywu
notjaywu previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@notjaywu notjaywu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cwangsmv
cwangsmv previously approved these changes Dec 3, 2024
View reviewed changes
@ihexxa
fix(cli): misc issues to keep order in running cli runner (#8223)
f14bf7a 
* fix(cli): cli should not prompt to ask for workspace id

* fix: support runing folder and sorting request by path

* fix: e2e tests

* fix: incorrect sorting
@notjaywu notjaywu dismissed stale reviews from cwangsmv and themself via f14bf7a December 4, 2024 07:22
notjaywu
notjaywu approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@notjaywu notjaywu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ihexxa ihexxa merged commit e238c90 into develop Dec 4, 2024
8 checks passed
@ihexxa ihexxa deleted the fix/runner/gen-ws-cmd branch December 4, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CurryYangxx CurryYangxx CurryYangxx left review comments

@notjaywu notjaywu notjaywu approved these changes

@cwangsmv cwangsmv cwangsmv left review comments

Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ihexxa @notjaywu @CurryYangxx @cwangsmv