Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Escape key closes environment editor modal in vim mode [INS-4975] #8368

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

pavkout
Copy link
Contributor

@pavkout pavkout commented Feb 13, 2025

Prevent CodeMirror from capturing escape key and shortcuts based on keymap settings

Closes INS-4975, 4877

@pavkout pavkout self-assigned this Feb 13, 2025
@pavkout pavkout requested a review from a team February 13, 2025 12:03
Copy link
Contributor

@ryan-willis ryan-willis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💟

@filfreire filfreire enabled auto-merge (squash) February 14, 2025 13:51
@filfreire filfreire merged commit 1ea0cee into Kong:develop Feb 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants