Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(per-commit) add a nightly label #501

Closed
wants to merge 1 commit into from
Closed

Conversation

gszr
Copy link
Member

@gszr gszr commented Jun 29, 2022

Historically, kong-build-tools would update the latest tag
for each new per-commit release. Since acfda16, that is no longer the
case.

Given it's useful to have a generic name for the latest build of
kong - and we want to avoid pushing a tag named latest, so as to avoid
surprises when users pull kong/kong- this commit adds a nightly tag.
Such tag will be used, for example, in decK's CI, where we want to test
against the latest available build of Kong.

Following this PR, the latest tag should also be removed from kong/kong
(it is still pointing to an old per-commit release).

(I am open to suggestions for a better name, since nightly doesn't really
represent the periodicity of the build -- it's generated per commit pushed to
Kong's master branch.)

@gszr
Copy link
Member Author

gszr commented Jun 29, 2022

Perhaps kong/kong:master instead of kong/kong:nightly?

@GGabriele
Copy link

+1 to kong/kong:master for me. That's more descriptive and gives a better idea of "what" and "where", instead of a misleading "when" for nightly.

Historically, kong-build-tools would update the `latest` tag
for each new per-commit release. Since acfda16, that is no longer the
case. Given it's useful to have a generic name for the latest build of
kong - and we want to avoid pushing a tag named `latest`, so as to avoid
surprises when users pull `kong/kong`- this commit adds a `nightly` tag.
Such tag will be used, for example, in decK's CI, where we want to test
against the latest available build of Kong.
@gszr gszr force-pushed the fix/add-nightly-tag branch from 9d9a211 to 976490b Compare June 30, 2022 14:01
@gszr
Copy link
Member Author

gszr commented Jun 30, 2022

+1 to kong/kong:master for me. That's more descriptive and gives a better idea of "what" and "where", instead of a misleading "when" for nightly.

👍 just pushed the change!

@aboudreault
Copy link
Contributor

looks similar to Kong/kong#9014?

@hutchic
Copy link
Contributor

hutchic commented Jul 7, 2022

adding onto @aboudreault looks similar to https://github.com/Kong/kong-ee/pull/3432 😂

@GGabriele
Copy link

So much parallel effort lol

So, what is the current status? As per the commit referenced by @aboudreault , does now latest matches the current master branch?

@gszr
Copy link
Member Author

gszr commented Aug 16, 2022

@hutchic Any updates on this? Should we merge or close this out? I see the EE PR got merged, but that should not affect this one.

@hutchic
Copy link
Contributor

hutchic commented Aug 22, 2022

I think we no longer need this with https://github.com/Kong/kong-ee/pull/3650 and Kong/kong#9168

@gszr
Copy link
Member Author

gszr commented Aug 23, 2022

Closing this. Thanks all!

@gszr gszr closed this Aug 23, 2022
@gszr gszr deleted the fix/add-nightly-tag branch August 23, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants