-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(per-commit) add a nightly
label
#501
Conversation
Perhaps |
+1 to |
Historically, kong-build-tools would update the `latest` tag for each new per-commit release. Since acfda16, that is no longer the case. Given it's useful to have a generic name for the latest build of kong - and we want to avoid pushing a tag named `latest`, so as to avoid surprises when users pull `kong/kong`- this commit adds a `nightly` tag. Such tag will be used, for example, in decK's CI, where we want to test against the latest available build of Kong.
9d9a211
to
976490b
Compare
👍 just pushed the change! |
looks similar to Kong/kong#9014? |
adding onto @aboudreault looks similar to https://github.com/Kong/kong-ee/pull/3432 😂 |
So much parallel effort lol So, what is the current status? As per the commit referenced by @aboudreault , does now |
@hutchic Any updates on this? Should we merge or close this out? I see the EE PR got merged, but that should not affect this one. |
I think we no longer need this with https://github.com/Kong/kong-ee/pull/3650 and Kong/kong#9168 |
Closing this. Thanks all! |
Historically, kong-build-tools would update the
latest
tagfor each new per-commit release. Since acfda16, that is no longer the
case.
Given it's useful to have a generic name for the latest build of
kong - and we want to avoid pushing a tag named
latest
, so as to avoidsurprises when users pull
kong/kong
- this commit adds anightly
tag.Such tag will be used, for example, in decK's CI, where we want to test
against the latest available build of Kong.
Following this PR, the
latest
tag should also be removed fromkong/kong
(it is still pointing to an old per-commit release).
(I am open to suggestions for a better name, since
nightly
doesn't reallyrepresent the periodicity of the build -- it's generated per commit pushed to
Kong's
master
branch.)