Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kconfig): remove kong version from kconfig.js #126

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

raoxiaoyan
Copy link
Contributor

@raoxiaoyan raoxiaoyan commented Nov 16, 2023

Summary

  1. Remove the Kong version from kconfig.js
  2. Retrieve the Kong version from useInfoStore.

Issue reference

FTI-5557

@raoxiaoyan raoxiaoyan requested a review from nekolab November 16, 2023 23:29
@raoxiaoyan raoxiaoyan merged commit b2a5055 into main Nov 17, 2023
18 checks passed
@raoxiaoyan raoxiaoyan deleted the fix/FTI-5557 branch November 17, 2023 06:28
@raoxiaoyan raoxiaoyan added backport release/3.4.x PRs should be cherry-picked to release/3.4.x backport release/3.5.x labels Dec 25, 2023
@team-gateway-bot
Copy link
Collaborator

The backport to release/3.5.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.5.x release/3.5.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.5.x
# Create a new branch
git switch --create backport-126-to-release/3.5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b2a5055ee92eafc4a75499f2ff07759e57fd9236
# Push it to GitHub
git push --set-upstream origin backport-126-to-release/3.5.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.5.x

Then, create a pull request where the base branch is release/3.5.x and the compare/head branch is backport-126-to-release/3.5.x.

@team-gateway-bot
Copy link
Collaborator

The backport to release/3.4.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.4.x release/3.4.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.4.x
# Create a new branch
git switch --create backport-126-to-release/3.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b2a5055ee92eafc4a75499f2ff07759e57fd9236
# Push it to GitHub
git push --set-upstream origin backport-126-to-release/3.4.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.4.x

Then, create a pull request where the base branch is release/3.4.x and the compare/head branch is backport-126-to-release/3.4.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/3.4.x PRs should be cherry-picked to release/3.4.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants