Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin): unified plugin forms #147

Merged
merged 5 commits into from
Dec 26, 2023
Merged

feat(plugin): unified plugin forms #147

merged 5 commits into from
Dec 26, 2023

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Dec 25, 2023 •
edited
Loading

Summary

This PR adopts the unified PluginForm and removes files used in the old plugin form.

Issue reference

Fix #[issue number]

@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review December 25, 2023 09:48
@Leopoldthecoder Leopoldthecoder changed the title feat(*): unified plugin forms feat(plugin): unified plugin forms Dec 25, 2023
sumimakito
sumimakito approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and looks good.

@Leopoldthecoder Leopoldthecoder merged commit df7adb7 into main Dec 26, 2023
18 checks passed
@Leopoldthecoder Leopoldthecoder deleted the feat/unified-plugin-form branch December 26, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumimakito sumimakito sumimakito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leopoldthecoder @sumimakito