This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
fix(headers) w3c return values and invalid handling #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikito
force-pushed
the
fix/w3c_return_values
branch
7 times, most recently
from
33f792e
to
ef774bf
Compare
kikito
force-pushed
the
fix/w3c_return_values
branch
from
ef774bf
to
9c3b346
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was returning an extra value (should_sample) in some cases, which was never used. It has been removed.
It now also early-exits when it finds a problem in the w3c header.
Thanks to @nvx for pointing this out!
Related: #80