-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(openssl): use kong openssl lib to build lua dev dependencies #382
fix(openssl): use kong openssl lib to build lua dev dependencies #382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from the test failures it seems that openssl is still required for other dependencies
…ry-and-headers-to-build-lua-dev-dependnecy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some suggestions, and we need the tests to pass.
looks like the tests fails on python missing out openssl |
Co-authored-by: Thijs Schreijer <thijs@thijsschreijer.nl>
all tests passed 🎉 ! |
Thank you @Tieske for reviewing and merging this! I will work on the pongo PR on kong-ee side now. |
I don't think luarocks uses pkgconfig, so that would not help (except for the pip dependency maybe). @hisham you probably know; see the changes in this PR. We're setting up some env vars to ensure we can build rocks with the proper version of openssl (the one shipped with Kong). If we add the info, as suggested by @fffonion in pkgconfig, would Luarocks then automatically pick that up? |
Currently Kong's docker image on master is based on ubuntu 22.04, which has moved to openssl 3.0, causing
inconsistency with the openssl Kong ships (1.1.1 series).