Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openssl): use kong openssl lib to build lua dev dependencies #382

Conversation

fffonion
Copy link
Contributor

@fffonion fffonion commented Feb 8, 2023

Currently Kong's docker image on master is based on ubuntu 22.04, which has moved to openssl 3.0, causing
inconsistency with the openssl Kong ships (1.1.1 series).

Tieske
Tieske previously approved these changes Mar 2, 2023
Copy link
Member

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the test failures it seems that openssl is still required for other dependencies

assets/Dockerfile Show resolved Hide resolved
@Tieske Tieske dismissed their stale review March 2, 2023 14:12

meant to ask for changes :)

Copy link
Member

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions, and we need the tests to pass.

assets/Dockerfile Show resolved Hide resolved
assets/Dockerfile Outdated Show resolved Hide resolved
@Tieske
Copy link
Member

Tieske commented Mar 3, 2023

looks like the tests fails on python missing out openssl

fffonion and others added 2 commits March 6, 2023 14:52
@fffonion
Copy link
Contributor Author

fffonion commented Mar 6, 2023

all tests passed 🎉 !

@Tieske Tieske changed the title fix(docker): use kong shipped openssl library and header to build lua dev dependencies fix(openssl): use kong openssl lib to build lua dev dependencies Mar 6, 2023
@Tieske Tieske merged commit 06d3909 into master Mar 6, 2023
@Tieske Tieske deleted the fix(docker)-use-kong-shipped-openssl-library-and-headers-to-build-lua-dev-dependnecy branch March 6, 2023 15:41
@fffonion
Copy link
Contributor Author

fffonion commented Mar 7, 2023

Thank you @Tieske for reviewing and merging this! I will work on the pongo PR on kong-ee side now.
Regarding the paths for openssl, it occurs to me that it might make sense to just provide a correct pkgconfig file
in the official docker image, so we don't even need to pass along env var/args. I will adjust that in later PRs, internal
ticket is KAG-833.

@Tieske
Copy link
Member

Tieske commented Mar 7, 2023

I don't think luarocks uses pkgconfig, so that would not help (except for the pip dependency maybe).

@hisham you probably know; see the changes in this PR. We're setting up some env vars to ensure we can build rocks with the proper version of openssl (the one shipped with Kong). If we add the info, as suggested by @fffonion in pkgconfig, would Luarocks then automatically pick that up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants