Skip to content

Commit

Permalink
fix(acme): correctly concat returned error (#11364)
Browse files Browse the repository at this point in the history
In the last change we added string concatenation the wrong way leading to empty logs. This addresses the problem

(cherry picked from commit 60b4312)
  • Loading branch information
zekth authored and gszr committed Nov 14, 2023
1 parent b10ec16 commit 5b373de
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@
[#10559](https://github.com/Kong/kong/pull/10559)
- **Zipkin**: Fixed an issue that traces not being generated correctly when instrumentations are enabled.
[#10983](https://github.com/Kong/kong/pull/10983)
- **Acme**: Fixed string concatenation on cert renewal errors
[#11364](https://github.com/Kong/kong/pull/11364)

#### PDK

Expand Down
3 changes: 2 additions & 1 deletion kong/plugins/acme/client.lua
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ local function order(acme_client, host, key, cert_type, rsa_key_size)

local cert, err = acme_client:order_certificate(key, host)
if err then
return nil, nil, "could not create certificate for host: ", host, " err: " .. err
local concatErr = "could not create certificate for host: " .. host .. " err: " .. err
return nil, nil, concatErr
end

return cert, key, nil
Expand Down

0 comments on commit 5b373de

Please sign in to comment.