Skip to content

Commit

Permalink
chore(plugin server) handle long delay when getting instance id (# 7809)
Browse files Browse the repository at this point in the history
  • Loading branch information
StarlightIbuki committed Apr 13, 2023
1 parent 78a56d1 commit da6053f
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion kong/runloop/plugin_servers/init.lua
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,20 @@ function get_instance_id(plugin_name, conf)
local key = type(conf) == "table" and kong.plugin.get_id() or plugin_name
local instance_info = running_instances[key]

local sleep_time = 0
local wait_count = 0
while instance_info and not instance_info.id do
-- some other thread is already starting an instance
ngx_sleep(0)
-- prevent busy-waiting
ngx_sleep(sleep_time)

-- to prevent a potential dead loop when someone failed to release the ID
wait_count = wait_count + 1
if wait_count > 10 then
sleep_time = 1
elseif wait_count > 20 then
return nil, "Could not claim instance_id for " .. plugin_name .. " (key: " .. key .. ")"
end
instance_info = running_instances[key]
end

Expand Down

0 comments on commit da6053f

Please sign in to comment.