Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unlimited ulimit #1384

Closed
subnetmarco opened this issue Jul 13, 2016 · 3 comments
Closed

Handle unlimited ulimit #1384

subnetmarco opened this issue Jul 13, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@subnetmarco
Copy link
Member

Handle the ulimit value in the CLI when it's unlimited and not a numeric value.

@subnetmarco subnetmarco added this to the 0.9 milestone Jul 13, 2016
@subnetmarco subnetmarco self-assigned this Jul 13, 2016
@Tieske
Copy link
Member

Tieske commented Jul 19, 2016

This sets/influences the values for; worker_rlimit_nofile and worker_connections.

should they be removed and left to the user to optimize (directly nginx config)?

@subnetmarco
Copy link
Member Author

It seems like by default worker_rlimit_nofile sets the value of the ulimit, so we can avoid setting it explicitly. But worker_connections by default is 512 and that definitely needs to be increased.

@Tieske
Copy link
Member

Tieske commented Jul 20, 2016

What is the proper value then?

imo 2 options;

  1. we retain current behaviour, but explicitly need to set a number when its "unlimited"
  2. only retain worker_connections and make it configurable in the config file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants