Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for nginx timer count #7670

Closed
rishabh-gupta2 opened this issue Jul 8, 2021 · 2 comments · Fixed by #8387
Closed

Support for nginx timer count #7670

rishabh-gupta2 opened this issue Jul 8, 2021 · 2 comments · Fixed by #8387
Labels
good first issue Issues that beginners/volunteers can easily help with. plugins/prometheus

Comments

@rishabh-gupta2
Copy link

The current plugin does not record nginx timers running.
Can we add a gauge to track ngx.timer.running_count() and ngx.timer.pending_count()

Let me know if this makes sense. I can pick this up and raise a PR.
@fffonion
Copy link
Contributor

fffonion commented Jul 8, 2021

@rishabh-gupta2 I agree that could be a valid feature. PR is welcomed!

@rishabh-gupta2
Copy link
Author

rishabh-gupta2 commented Jul 8, 2021 •
edited
Loading

Sure Thanks, @fffonion , Will raise PR for this

@gszr gszr transferred this issue from Kong/kong-plugin-prometheus Aug 7, 2021
@mayocream mayocream added the good first issue Issues that beginners/volunteers can easily help with. label Jan 12, 2022
@limkevinkuan limkevinkuan mentioned this issue Feb 9, 2022
Merged
limkevinkuan added a commit to limkevinkuan/kong that referenced this issue Feb 10, 2022
@limkevinkuan
feat(prometheus) add nginx timer metrics
571cc0d 
This adds gauges to track ngx.timer.running_count() and ngx.timer.pending_count() as requested in Kong#7670.
mayocream pushed a commit that referenced this issue Feb 23, 2022
@limkevinkuan
feat(prometheus) add nginx timer metrics (#8387)
d02d4b1 
* feat(prometheus) add nginx timer metrics

This adds gauges to track ngx.timer.running_count() and ngx.timer.pending_count() as requested in #7670.

* style(prometheus) rename metrics from current timers to just timers

Per suggestion, to avoid confusion.

* fix(prometheus) fix timer tests failing

The tests were accidentally matching in plain mode so '%d+' was not
understood.

* perf(prometheus) localize ngx timer functions
kikito pushed a commit that referenced this issue Feb 24, 2022
@limkevinkuan @kikito
feat(prometheus) add nginx timer metrics (#8387)
3ab08c5 
* feat(prometheus) add nginx timer metrics

This adds gauges to track ngx.timer.running_count() and ngx.timer.pending_count() as requested in #7670.

* style(prometheus) rename metrics from current timers to just timers

Per suggestion, to avoid confusion.

* fix(prometheus) fix timer tests failing

The tests were accidentally matching in plain mode so '%d+' was not
understood.

* perf(prometheus) localize ngx timer functions
kikito pushed a commit that referenced this issue Feb 24, 2022
@limkevinkuan @kikito
feat(prometheus) add nginx timer metrics (#8387)
ea9c4da 
* feat(prometheus) add nginx timer metrics

This adds gauges to track ngx.timer.running_count() and ngx.timer.pending_count() as requested in #7670.

* style(prometheus) rename metrics from current timers to just timers

Per suggestion, to avoid confusion.

* fix(prometheus) fix timer tests failing

The tests were accidentally matching in plain mode so '%d+' was not
understood.

* perf(prometheus) localize ngx timer functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that beginners/volunteers can easily help with. plugins/prometheus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(prometheus) add nginx timer metrics limkevinkuan/kong
4 participants
@fffonion @gszr @mayocream @rishabh-gupta2