fix(pdk): request.get_raw_query #10164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
force-pushed
the
fix/pdk-get-raw-query
branch
from
315f318 to
60ca67e
Compare
Avoid accessing ngx.var.args and fetch the raw query string from the request_uri. Accessing ngx.var.args was causing issue #10080. We might want to restrict access to happen solely via ngx.var.* in the future and/or to implement some index refreshing logic in lua-kong-nginx-module but right now this is the easiest way to avoid the problem in the pdk.
samugi
force-pushed
the
fix/pdk-get-raw-query
branch
from
60ca67e to
e19eaac
Compare
|
closing in favor of: Kong/lua-kong-nginx-module#59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avoid accessing
ngx.var.argsand fetch the raw query string from the request_uri instead.Alternatives could be restricting access to happen only via ngx.var.* or implementing some index clearing logic in lua-kong-nginx-module by patching set_uri_args().
Possibly going to close this in favor of: Kong/lua-kong-nginx-module#59
Fix #10080
KAG-410