Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci) add schema-change-noteworthy label for any schema.lua file change #10342

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

hbagdi
Copy link
Member

@hbagdi hbagdi commented Feb 21, 2023

Summary

This commit updates the CI configuration to add the "schema-change-noteworthy" label for every PR that touches any schema.lua file. This helps communicate schema changes in Kong to downstream projects like Konnect, decK, KIC, Kong Manager track each and every schema change and adapt accordingly.

Checklist

  • The Pull Request has tests - Not needed
  • There's an entry in the CHANGELOG - Not needed
  • There is a user-facing docs PR - Not Needed

@hbagdi hbagdi requested a review from kikito February 21, 2023 22:23
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Feb 21, 2023
Copy link
Member

@gszr gszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about custom daos - e.g., kong/plugins/**/daos (OSS) and plugins-ee/**/daos.lua?

@hbagdi
Copy link
Member Author

hbagdi commented Feb 22, 2023

@gszr Added the open-source plugin DAOs to the patch. EE is not in the scope of this patch.

@gszr gszr merged commit 80a5d3b into master Feb 23, 2023
@gszr gszr deleted the chore/schema-label branch February 23, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not part of the core functionality of kong, but still needed size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants