Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(balancer) use local target cache #10384

Merged
merged 2 commits into from
Feb 28, 2023
Merged

fix(balancer) use local target cache #10384

merged 2 commits into from
Feb 28, 2023

Conversation

locao
Copy link
Contributor

@locao locao commented Feb 27, 2023

Summary

The target's global cache was caching more data than it should: it kept data retrieved from the database and DNS name resolution, which has its own cache.

As a result, when config reloads were done, some processes were skipped (such as setting the upstream as healthy) because the load-balancer never identified the data as new if it was the same as cached (highly probable with DNS name resolution).

This change makes the target cache local to the worker.

Checklist

Full changelog

  • Make the target cache local to the worker.
  • This PR has no tests. This is a race condition, almost impossible to automate.

Issue reference

FTI-3172
Fix #8517
Fix #10020

@locao locao merged commit 4f29d72 into master Feb 28, 2023
@locao locao deleted the fix/local_target_cache_3x branch February 28, 2023 21:44
@team-gateway-bot
Copy link
Collaborator

The backport to release/2.8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.8.x release/2.8.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.8.x
# Create a new branch
git switch --create backport-10384-to-release/2.8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4f29d72d00b3278a2c12fb67a073c3c985f5b434
# Push it to GitHub
git push --set-upstream origin backport-10384-to-release/2.8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.8.x

Then, create a pull request where the base branch is release/2.8.x and the compare/head branch is backport-10384-to-release/2.8.x.

team-gateway-bot pushed a commit that referenced this pull request Mar 1, 2023
* fix(balancer) use local target cache

* fix(targets): remove dup code

(cherry picked from commit 4f29d72)
team-gateway-bot pushed a commit that referenced this pull request Mar 1, 2023
* fix(balancer) use local target cache

* fix(targets): remove dup code

(cherry picked from commit 4f29d72)
team-gateway-bot pushed a commit that referenced this pull request Mar 1, 2023
* fix(balancer) use local target cache

* fix(targets): remove dup code

(cherry picked from commit 4f29d72)
locao added a commit that referenced this pull request Mar 1, 2023
* fix(balancer) use local target cache

* fix(targets): remove dup code

(cherry picked from commit 4f29d72)

Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
locao added a commit that referenced this pull request Mar 1, 2023
* fix(balancer) use local target cache

* fix(targets): remove dup code

(cherry picked from commit 4f29d72)

Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
locao added a commit that referenced this pull request Mar 1, 2023
* fix(balancer) use local target cache

* fix(targets): remove dup code

(cherry picked from commit 4f29d72)

Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
@kikito kikito mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants