-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(balancer) use local target cache #10384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
reviewed
Feb 28, 2023
locao
force-pushed
the
fix/local_target_cache_3x
branch
from
February 28, 2023 12:24
08e3ef0
to
0c0984f
Compare
samugi
approved these changes
Feb 28, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.8.x release/2.8.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.8.x
# Create a new branch
git switch --create backport-10384-to-release/2.8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4f29d72d00b3278a2c12fb67a073c3c985f5b434
# Push it to GitHub
git push --set-upstream origin backport-10384-to-release/2.8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.8.x Then, create a pull request where the |
team-gateway-bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
* fix(balancer) use local target cache * fix(targets): remove dup code (cherry picked from commit 4f29d72)
team-gateway-bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
* fix(balancer) use local target cache * fix(targets): remove dup code (cherry picked from commit 4f29d72)
team-gateway-bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
* fix(balancer) use local target cache * fix(targets): remove dup code (cherry picked from commit 4f29d72)
locao
added a commit
that referenced
this pull request
Mar 1, 2023
locao
added a commit
that referenced
this pull request
Mar 1, 2023
locao
added a commit
that referenced
this pull request
Mar 1, 2023
Closed
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The target's global cache was caching more data than it should: it kept data retrieved from the database and DNS name resolution, which has its own cache.
As a result, when config reloads were done, some processes were skipped (such as setting the upstream as healthy) because the load-balancer never identified the data as new if it was the same as cached (highly probable with DNS name resolution).
This change makes the target cache local to the worker.
Checklist
Full changelog
Issue reference
FTI-3172
Fix #8517
Fix #10020