fix(jwt): offload ECDSA signature format conversion #10463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this patch we transformed signature formats in the `jwt_parser` module to the specified signature format See The RFC for more details: https://www.rfc-editor.org/rfc/rfc7518#section-3.4 `lua-resty-openssl` 0.8.18 can do do this directly. Fixes: https://konghq.atlassian.net/browse/KAG-844 Signed-off-by: Joshua Schmid <jaiks@posteo.de>
Signed-off-by: Joshua Schmid <jaiks@posteo.de>
jschmid1
changed the title
fffonion
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
before this patch we transformed signature formats in the
jwt_parsermodule to the specified signature formatSee The RFC for more details: https://www.rfc-editor.org/rfc/rfc7518#section-3.4
lua-resty-openssl0.8.18 can do do this directly.Signed-off-by: Joshua Schmid jaiks@posteo.de
Checklist
- [ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HEREFull changelog
lua-resty-opensslto 0.8.18