Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clustering/dp): add support for dataplane labels #10471

Merged
merged 5 commits into from
Mar 28, 2023
Merged

feat(clustering/dp): add support for dataplane labels #10471

merged 5 commits into from
Mar 28, 2023

Conversation

samugi
Copy link
Member

@samugi samugi commented Mar 13, 2023 •
edited
Loading

Summary

Data Plane labels capability for Konnect

Checklist

Full changelog

  • [Implement ...]

KAG-587
KAG-826

@samugi samugi marked this pull request as draft March 13, 2023 16:01
@samugi samugi force-pushed the feat/dp-labels branch 3 times, most recently from 8298a11 to 41c2ab5 Compare March 14, 2023 14:19
@hbagdi
Copy link
Member

hbagdi commented Mar 14, 2023

Please hold. This feature is undergoing a bit more discussion from our product teams and there may be a change of direction here.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Mar 21, 2023
@samugi samugi changed the title feat(db-labels): add support for dataplane labels feat(dp-labels): add support for dataplane labels Mar 21, 2023
@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 21, 2023
hbagdi
hbagdi reviewed Mar 22, 2023
View reviewed changes
kong.conf.default Outdated Show resolved Hide resolved
@samugi samugi force-pushed the feat/dp-labels branch 2 times, most recently from 6572e9f to 3e10d84 Compare March 23, 2023 20:33
@samugi samugi marked this pull request as ready for review March 23, 2023 20:34
@samugi samugi requested a review from chronolaw March 23, 2023 20:38
hbagdi
hbagdi reviewed Mar 23, 2023
View reviewed changes
kong.conf.default Outdated Show resolved Hide resolved
@samugi samugi force-pushed the feat/dp-labels branch 3 times, most recently from b2eef58 to deac581 Compare March 24, 2023 19:09
@samugi samugi added this to the 3.3 milestone Mar 26, 2023
@samugi samugi force-pushed the feat/dp-labels branch 3 times, most recently from 98c7225 to 70178ec Compare March 27, 2023 20:52
chronolaw
chronolaw reviewed Mar 28, 2023
View reviewed changes
kong/tools/utils.lua Outdated Show resolved Hide resolved
kong/tools/utils.lua Outdated Show resolved Hide resolved
kong/tools/utils.lua Outdated Show resolved Hide resolved
kong/tools/utils.lua Outdated Show resolved Hide resolved
kong/tools/utils.lua Outdated Show resolved Hide resolved
kong/tools/utils.lua Outdated Show resolved Hide resolved
kong/tools/utils.lua Outdated Show resolved Hide resolved
kong/tools/utils.lua Outdated Show resolved Hide resolved
chronolaw
chronolaw reviewed Mar 28, 2023
View reviewed changes
kong/tools/utils.lua Outdated Show resolved Hide resolved
kong/tools/utils.lua Outdated Show resolved Hide resolved
kong/tools/utils.lua Outdated Show resolved Hide resolved
@samugi samugi force-pushed the feat/dp-labels branch 3 times, most recently from f8d2007 to dea4f2a Compare March 28, 2023 04:40
chronolaw
chronolaw reviewed Mar 28, 2023
View reviewed changes
kong/clustering/data_plane.lua Outdated Show resolved Hide resolved
kong/tools/utils.lua Outdated Show resolved Hide resolved
kong/tools/utils.lua Outdated Show resolved Hide resolved
@chronolaw chronolaw changed the title feat(dp-labels): add support for dataplane labels feat(clustering/dp): add support for dataplane labels Mar 28, 2023
chronolaw
chronolaw reviewed Mar 28, 2023
View reviewed changes
kong/clustering/data_plane.lua Outdated Show resolved Hide resolved
kong/tools/utils.lua Show resolved Hide resolved
bungle
bungle approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@samugi samugi merged commit ab95a28 into master Mar 28, 2023
@samugi samugi deleted the feat/dp-labels branch March 28, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbagdi hbagdi hbagdi left review comments

@chronolaw chronolaw chronolaw left review comments

@bungle bungle bungle approved these changes

Assignees

@samugi samugi

Labels
changelog core/clustering core/configuration core/templates size/L
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@samugi @hbagdi @bungle @chronolaw