Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(healthchecker): fix passive healthchecker in subrequest #10592

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

oowl
Copy link
Member

@oowl oowl commented Mar 31, 2023

Summary

fix passive health checker in subrequest

Checklist

  • The Pull Request has tests
  • There's an entry in the CHANGELOG

Full changelog

  • fix passive health checker in subrequest

Issue reference

FTI-4841
#10550

@hbagdi
Copy link
Member

hbagdi commented Mar 31, 2023

Please hold merge until the PR template is fleshed out.

@windmgc windmgc merged commit 38a0d0e into master Apr 3, 2023
@windmgc windmgc deleted the fix/passive_health_check branch April 3, 2023 10:20
@hbagdi
Copy link
Member

hbagdi commented Apr 3, 2023

@windmgc @attenuation Please cherry pick this change to EE.

@ghost
Copy link

ghost commented Apr 3, 2023

I have noticed that even without the fix in kong/runloop/handler.lua, the test cases can still pass. I'm not sure if this phenomenon only exists in my environment.

@outsinre
Copy link
Contributor

It is covered by CE2EE master merge PR: https://github.com/Kong/kong-ee/pull/4985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants