fix(proxy): fix request buffering for HTTP/2.0 #10595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
bungle
force-pushed
the
fix/request-buffering-http2-rebased
branch
2 times, most recently
from
e3c7f52
to
c92202c
Compare
bungle
force-pushed
the
fix/request-buffering-http2-rebased
branch
2 times, most recently
from
efbffec
to
10c20a0
Compare
### Summary Turning request/response buffering off for HTTP/2.0 is not possible. There is a check that causes buffering only to be controllable for HTTP/1.1. This was probably done because of an issue in nginx, which was fixed in version 1.9.14 (http://nginx.org/en/docs/http/ngx_http_v2_module.html): > Before version 1.9.14, buffering of a client request body could not be > disabled regardless of [proxy_request_buffering](http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_request_buffering), > [fastcgi_request_buffering](http://nginx.org/en/docs/http/ngx_http_fastcgi_module.html#fastcgi_request_buffering), > [uwsgi_request_buffering](http://nginx.org/en/docs/http/ngx_http_uwsgi_module.html#uwsgi_request_buffering), and > [scgi_request_buffering](http://nginx.org/en/docs/http/ngx_http_scgi_module.html#scgi_request_buffering) directive values. Kong now has Nginx > 1.9.14, so the check is not needed any more. The work was done by @PidgeyBE, thank you very much! ### Issues Resolved Fix #7418 Close #10204 Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
force-pushed
the
fix/request-buffering-http2-rebased
branch
from
10c20a0
to
9547c53
Compare
hanshuebner
approved these changes
Mar 31, 2023
bungle
added a commit
that referenced
this pull request
Mar 31, 2023
### Summary Master is currently red because of #10595 (was green when merged), this is an attempt to fix it. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
hanshuebner
pushed a commit
that referenced
this pull request
Mar 31, 2023
### Summary Master is currently red because of #10595 (was green when merged), this is an attempt to fix it. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
that referenced
this pull request
Mar 31, 2023
### Summary Master is currently red because of #10595 (was green when merged), this is a second attempt to fix it. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
that referenced
this pull request
Mar 31, 2023
### Summary Master is currently red because of #10595 (was green when merged), this is a second attempt to fix it. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
that referenced
this pull request
Mar 31, 2023
### Summary Master is currently red because of #10595 (was green when merged), this is a final attempt to fix it, but disabling Lua cURL tests, and removing the CI modifications because of it. We need to get back on board to get it right. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
that referenced
this pull request
Mar 31, 2023
### Summary Master is currently red because of #10595 (was green when merged), this is a final attempt to fix it, but disabling Lua cURL tests, and removing the CI modifications because of it. We need to get back on board to get it right. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
|
@bungle please cherry-pick into kong-ee |
|
@bungle ping on this cherry-pick |
|
cherrypicked to ee in https://github.com/Kong/kong-ee/commit/0354778de73400dbe1dcac2b85de4cd006bd0495 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Turning request/response buffering off for HTTP/2.0 is not possible. There is a check that causes buffering only to be controllable for HTTP/1.1.
This was probably done because of an issue in nginx, which was fixed in version 1.9.14 (http://nginx.org/en/docs/http/ngx_http_v2_module.html):
Kong now has Nginx > 1.9.14, so the check is not needed any more.
The work was done by @PidgeyBE, thank you very much!
Issues Resolved
Fix #7418
Close #10204