-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(clustering/compat): style clean for checkers array #10858
Conversation
@liverpool8056 , I remove |
@chronolaw Yes, it's ok, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this change tested?
I did not change the logic, so the original test cases should still work if they do have one. |
Do automated tests exist? How did you verify that the logic is unchanged? |
2e9c88a
to
b1ec93f
Compare
b1ec93f
to
37bac59
Compare
Rebase to #10759, more test cases to ensure it is correct. |
Summary
We should not put all un-related checking logic into one function,
this PR moves queue and valuts checking code to new functions.
Checklist