Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): eliminate duplicate mig http_server #10867

Closed
wants to merge 2 commits into from

Conversation

StarlightIbuki
Copy link
Contributor

Summary

Some tests are using their own copy of http_server, and some are using static ports for testing. Some also do not kill the thread if the test fails.

Solution: see Full changelog.

Checklist

(Do we need to backport this?)

  • The Pull Request has backports to all the versions it needs to cover

Full changelog

  • Rewrite to use the http_server in the helper;
  • Rewrite to use dynamic ports for every test;
  • Kill threads at after_each

Issue reference

Partial fix of KAG-1148

@StarlightIbuki StarlightIbuki force-pushed the chore/plugin-server-flaky branch from f3fa94d to e7a409b Compare May 16, 2023 06:13
@StarlightIbuki StarlightIbuki marked this pull request as draft May 16, 2023 09:05
@StarlightIbuki
Copy link
Contributor Author

Closing as we have a new HTTP mocking implementation.
Refer: #10885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant