fix(cassandra) add a 'port' option for clusters #1151
Merged
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clusters with nodes not running on the default `9042` port couldn't be properly reached by Kong. This bumps the driver (including the fix), and adds a `port` options to the configuration. Thanks @allisthere2love for the investigation. This issue was never encountered before and my guess is because such clusters added their contact_points including the port (`x.x.x.x:9043`), and the driver could connect to it, but not to the other nodes, since it was trying `9042` on those. So it simply considered the other nodes as DOWN, and thus still works (if one doesn't check the logs and those lags are not displaying warnings, it seems like nothing is going wrong). However @allisthere2love had nodes from another C* cluster listening on `9042`, leading to inconsistencies and thus, actual errors that allowed us to track it down. As per other datastax drivers, all nodes of a cluster must listen on the same port. Fix #1139 See thibaultcha/lua-cassandra#47
thibaultcha
added
the
pr/ready (but hold merge)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clusters with nodes not running on the default
9042port couldn't beproperly reached by Kong. This bumps the driver (including the fix), and
adds a
portoptions to the configuration. Thanks @allisthere2love forthe investigation.
This issue was never encountered before and my guess is because such
clusters added their contact_points including the port (
x.x.x.x:9043),and the driver could connect to it, but not to the other nodes, since it
was trying
9042on those. So it simply considered the other nodes asDOWN, and thus still worked from an outsider's POV (if one doesn't check the logs and those lags
are not displaying warnings, it seems like nothing is going wrong).
However @allisthere2love had nodes from another C* cluster listening on
9042, leading to inconsistencies and thus, actual errors that allowedus to track it down.
As per other datastax drivers, all nodes of a cluster must listen on the
same port.
Fix #1139
See thibaultcha/lua-cassandra#47