[backport -> release/3.2.x] fix(dns): Eliminate asynchronous timer in syncQuery() to prevent hang #12104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/balancer
core/proxy
core/clustering
plugins/datadog
plugins/statsd
plugins/http-log
core/db
core/configuration
core/docs
chore
chobits
force-pushed
the
backport-11900-to-release/3.2.x
branch
from
dfa30db to
5346552
Compare
github-actions
bot
removed
core/balancer
core/proxy
core/clustering
plugins/datadog
plugins/statsd
plugins/http-log
core/db
core/configuration
core/docs
chore
chobits
force-pushed
the
backport-11900-to-release/3.2.x
branch
2 times, most recently
from
6d61d7e to
c757b54
Compare
- Stop retrying in dns/client.lua, let the resolver handle this. This change also makes it possible to disable retries, which previously was not possible - Be more faithful to the timeouts set by the user. Previously, the timeout configured was used only for the ultimate request sent to the DNS server, but asynchronous requests allowed longer timeouts which was not transparent. - When the DNS server fails, stop trying other query types. Previously, the behavior was such that after an (intermediate) failure to query for one record type (say "SRV"), the client would try the next record type (say "A") and succeed with that. It would then return the contents of the "A" record even if the "SRV" record pointed to a different address. - Change domain names used for testing the DNS client into the kong-gateway-testing.link zone, which is controlled by the Kong Gateway team. Fixes #10182 KAG-2300
…adlock risk (#11900) * fix(dns): introduce the synchronous query in syncQuery() to prevent hang risk Originally the first request to `syncQuery()` will trigger an asynchronous timer event, which added the risk of thread pool hanging. With this patch, cold synchronously DNS query will always happen in the current thread if current phase supports yielding. Fix FTI-5348 --------- Co-authored-by: Datong Sun <datong.sun@konghq.com>
chobits
force-pushed
the
backport-11900-to-release/3.2.x
branch
from
c757b54 to
9641125
Compare
|
After we merged this #12031, we can rebase this branch with the latest release 3.2.x. |
ADD-SP
approved these changes
Nov 29, 2023
dndx
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #11900 and #11386 to 3.2.x