fix(balancer): respect max retries #12242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catbro666
reviewed
Dec 25, 2023
build/openresty/patches/ngx_lua-0.10.25_01-dyn_upstream_keepalive.patch
Outdated
Show resolved
Hide resolved
catbro666
reviewed
Dec 25, 2023
build/openresty/patches/ngx_lua-0.10.25_01-dyn_upstream_keepalive.patch
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
chore
oowl
reviewed
Jan 2, 2024
|
review companion: https://github.com/Kong/openresty-patches-review/pull/1/files |
|
new review companion: https://github.com/Kong/openresty-patches-review/pull/9/files |
oowl
approved these changes
Jan 3, 2024
ms2008
reviewed
Jan 3, 2024
ms2008
approved these changes
Jan 4, 2024
catbro666
reviewed
Jan 4, 2024
build/openresty/patches/ngx_lua-0.10.25_01-dyn_upstream_keepalive.patch
Outdated
Show resolved
Hide resolved
catbro666
approved these changes
Jan 5, 2024
|
Openresty patches review companion may not related to this pr and cc @fffonion |
|
a rebase will now solve the failing openresty patches companion CI @tzssangglass |
In the balancer phase, when obtaining a connection from the upstream connection pool, the `cached` attribute of the peer connection is set to 1(`pc->cached = 1;`), indicating that the connection is obtained from the cache. If an error occurs during the use of this connection, such as "upstream prematurely closed connection" the system will increase the `tries` attribute of the peer connection by executing `u->peer.tries++`. `tries` represents the maximum number of attempts to connect to an upstream server. It is equal to the normal 1 attempt + `retries` (default value is 5) = 6. The occurrence of `u->peer.tries++` is unexpected and it results in the actual retry count exceeding 6 in worst cases. This PR restores tries by callbacks to the balancer when `u->peer.tries++` is unexpectedly set. FIX [FTI-5616](https://konghq.atlassian.net/browse/FTI-5616) Signed-off-by: tzssangglass <tzssangglass@gmail.com>
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
tzssangglass
force-pushed
the
FTI-5616
branch
from
e3701bd to
7d69919
Compare
|
Due to some issues, I am unable to continue working on this PR until it is merged, so I have created a new PR #12346. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the balancer phase, when obtaining a connection from the upstream connection pool, the
cachedattribute of the peer connection is set to 1(pc->cached = 1;), indicating that the connection is obtained from the cache.If an error occurs during the use of this connection, such as "upstream prematurely closed connection" the system will increase the
triesattribute of the peer connection by executingu->peer.tries++.triesrepresents the maximum number of attempts to connect to an upstream server. It is equal to the normal 1 attempt +retries(default value is 5) = 6.The occurrence of
u->peer.tries++is unexpected and it results in the actual retry count exceeding 6 in worst cases.This PR restores tries by callbacks to the balancer when
u->peer.tries++is unexpectedly set.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix FTI-5616