Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): trigger a workflow for reviewing patches #12277

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

fffonion
Copy link
Contributor

@fffonion fffonion commented Jan 2, 2024

Summary

This PR adds a workflow that opens a companion PR (the link being displayed as mentioning current PR) when developer
opens a PR that modifies openresty patches.
The companion PR (like https://github.com/Kong/openresty-patches-review/pull/6) automatically creates and updates
in-place when the PR at kong or kong-ee updates, and displays only the diffs for patches files to help reviewer
understand the changes better.

Checklist

  • [na] The Pull Request has tests
  • [na] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [na] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added chore Not part of the core functionality of kong, but still needed build/bazel labels Jan 2, 2024
@fffonion fffonion force-pushed the trigger-patch branch 7 times, most recently from 4334ee0 to 45b0de5 Compare January 2, 2024 14:00
@fffonion fffonion changed the title Trigger patch feat(ci): trigger a workflow for reviewing patches Jan 2, 2024
@fffonion fffonion marked this pull request as ready for review January 2, 2024 14:22
@fffonion
Copy link
Contributor Author

fffonion commented Jan 2, 2024

The multiple mentioning is occured only during testing, now it only creates a single PR at the kong/openresty-patches-review repo and updates in-place.

Copy link
Member

@samugi samugi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome!

@fffonion fffonion merged commit 064f3f6 into master Jan 4, 2024
23 checks passed
@fffonion fffonion deleted the trigger-patch branch January 4, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/bazel chore Not part of the core functionality of kong, but still needed size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants