Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugins): Request-Transformer rename behavior #13358

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix(plugins): Request-Transformer rename behavior #13358

merged 1 commit into from
Aug 15, 2024

Conversation

StarlightIbuki
Copy link
Contributor

@StarlightIbuki StarlightIbuki commented Jul 10, 2024 •
edited
Loading

Summary

This plugin removes the target parameter when renaming from the same parameter.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-4915

Also see #9442

@github-actions github-actions bot added plugins/request-transformer cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jul 10, 2024
@StarlightIbuki StarlightIbuki marked this pull request as draft July 10, 2024 09:52
@pull-request-size pull-request-size bot added size/S and removed size/M labels Jul 10, 2024
@StarlightIbuki StarlightIbuki marked this pull request as ready for review July 25, 2024 07:51
@StarlightIbuki StarlightIbuki marked this pull request as draft July 26, 2024 06:51
@pull-request-size pull-request-size bot added size/L and removed size/S labels Jul 30, 2024
@StarlightIbuki StarlightIbuki marked this pull request as ready for review July 30, 2024 08:44
windmgc
windmgc reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@windmgc windmgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure if it is designed on purpose, what would most people expect in this scenario? (Because it seems like the behavior has been existing for a long time, and this is the first time we received a question about it)

kong/plugins/request-transformer/access.lua Outdated Show resolved Hide resolved
@team-eng-enablement team-eng-enablement added author/community PRs from the open-source community (not Kong Inc) and removed author/community PRs from the open-source community (not Kong Inc) labels Aug 13, 2024
@catbro666
Copy link
Contributor

How about also adding a test in which oldname and newname are exactly the same?

@ADD-SP ADD-SP merged commit 3b8685a into master Aug 15, 2024
26 checks passed
@ADD-SP ADD-SP deleted the fix/req-trans-rename branch August 15, 2024 09:17
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flrgh flrgh flrgh left review comments

@ADD-SP ADD-SP ADD-SP approved these changes

@catbro666 catbro666 catbro666 approved these changes

@windmgc windmgc Awaiting requested review from windmgc

Assignees

@StarlightIbuki StarlightIbuki

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/request-transformer size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@StarlightIbuki @catbro666 @team-gateway-bot @windmgc @flrgh @ADD-SP @team-eng-enablement