fix(venv): fix compatibility on Bash 4.x and sync changes from EE #13704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
team-gateway-bot
added
the
author/community
Water-Melon
approved these changes
Sep 29, 2024
oowl
approved these changes
Sep 29, 2024
fffonion
removed
the
cherry-pick kong-ee
github-actions
bot
added
the
cherry-pick kong-ee
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13704-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13704-to-master-to-upstream
git checkout -b cherry-pick-13704-to-master-to-upstream
ancref=$(git merge-base 8210e880c603186eff8154c731bb392d1413f3fa 293fca78a5f4952a39ef6cb75fc6c22e1a4c16c5)
git cherry-pick -x $ancref..293fca78a5f4952a39ef6cb75fc6c22e1a4c16c5 |
github-actions
bot
added
the
incomplete-cherry-pick
|
Manually cherry-pick: https://github.com/Kong/kong-ee/pull/10323 |
ADD-SP
removed
the
author/community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Bash 3 is the default shell on macOS it seems
https://github.com/Kong/kong-ee/pull/10323