Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(*): update the changelog PR title to include the docs(release) scope #13719

Merged
merged 1 commit into from
Sep 30, 2024
Merged

docs(*): update the changelog PR title to include the docs(release) scope #13719

merged 1 commit into from
Sep 30, 2024

Conversation

AndyZhang0707
Copy link
Collaborator

@AndyZhang0707 AndyZhang0707 commented Sep 29, 2024 •
edited
Loading

Summary

The tool didn't include the "docs(release)" scope in the changelog PR title previously and sometime it leads to incorrect commit messages when moderators try to use "squash and merge". This change is to add the scope to the PR title.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-5216

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Sep 29, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 29, 2024
@AndyZhang0707 AndyZhang0707 merged commit 7558b4d into master Sep 30, 2024
22 of 24 checks passed
@AndyZhang0707 AndyZhang0707 deleted the update-changelog-pr-title branch September 30, 2024 02:29
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

curiositycasualty pushed a commit that referenced this pull request Oct 15, 2024
@team-gateway-bot @AndyZhang0707
docs(*): update the changelog PR title to include the docs(release) s…
e43eb11 
…cope (#13719) (#10366)

(cherry picked from commit 7558b4d)

Co-authored-by: Andy Zhang <AndyZhang0707@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProBrian ProBrian ProBrian approved these changes

@outsinre outsinre outsinre approved these changes

Assignees

@AndyZhang0707 AndyZhang0707

Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XS skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndyZhang0707 @team-gateway-bot @outsinre @ProBrian