Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Bazel): format Bazel files by Bazel Buildifier #13720

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Sep 29, 2024

Summary

Format Bazel files using https://github.com/bazelbuild/buildtools/blob/main/buildifier/README.md.

Checklist

  • [N/A] The Pull Request has tests
  • [N/A] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

https://konghq.atlassian.net/browse/KAG-5491

@ADD-SP ADD-SP added skip-changelog incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention labels Sep 29, 2024
@github-actions github-actions bot added chore Not part of the core functionality of kong, but still needed build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Sep 29, 2024
@ADD-SP
Copy link
Contributor Author

ADD-SP commented Sep 29, 2024

@pull-request-size pull-request-size bot added size/M and removed size/L labels Sep 29, 2024
@ADD-SP ADD-SP marked this pull request as ready for review September 29, 2024 10:16
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 29, 2024
@ADD-SP ADD-SP removed the author/community PRs from the open-source community (not Kong Inc) label Sep 29, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 29, 2024
@ADD-SP ADD-SP removed the author/community PRs from the open-source community (not Kong Inc) label Sep 30, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 30, 2024
@ADD-SP ADD-SP removed the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Sep 30, 2024
@@ -39,8 +39,8 @@ configure_make(
kong_template_genrule(
name = "luarocks_exec",
srcs = [
"@openssl//:openssl",
"@libexpat//:libexpat",
"@libexpat",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearly specifying the target makes it easier to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) build/bazel chore Not part of the core functionality of kong, but still needed incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention size/M skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants