[refactor] drop pcre regexes for lua patterns #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
force-pushed
the
refactor/patterns
branch
from
9fce0df to
93fd629
Compare
|
Removing PCRE as a dependency would prevent anyone from using regular expressions in their plugins? Would we want to use it for handling regex based routing? Even if we're not using it now or in the future I think it should be available for third-party plugin authors. |
thibaultcha
force-pushed
the
refactor/patterns
branch
from
93fd629 to
a933c54
Compare
|
Patterns can also do a great job. It depends what we want to use. This (or at least a part of it) can still be merged (it's lighter than what we used to have, especially for the specs) and it doesn't remove the actual compilation with pcre (as said in the PR). If we don't remove pcre, then #167 is irrelevant. |
- switch `public_dns` validation from regex to a custom function with pattern validation (in its schema) - remove regex field in schemas and schemas.lua - uuid validation now happens with patterns in base_dao.lua
This does not remove the installation of pcre in the package build or the openresty installation of travis-ci.
thibaultcha
force-pushed
the
refactor/patterns
branch
3 times, most recently
from
cf94bce to
46525b5
Compare
thibaultcha
force-pushed
the
refactor/patterns
branch
from
46525b5 to
2cf80ea
Compare
|
Changes Unknown when pulling 663e130 on refactor/patterns into * on master*. |
thibaultcha
added a commit
that referenced
this pull request
May 9, 2015
[refactor] drop pcre regexes for lua patterns
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
[refactor] drop pcre regexes for lua patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion we had in #167, this PR removes the need for patterns everywhere accross Kong.
regexfield in schemas is not supported anymore. One now needs to usefuncand use Lua patterns.Finally, I would say I really like the idea of lightening the crazy amount of dependencies Kong requires, but I am not yet 100% sure about that one. pcre is recommended by openresty here (sure, we can probably drop it if we don't use it), but future plugins might eventually want to use Perl regexps, which this will be preventing. However, plugins (and the core) could still use powerful lua pattern libraries (LPeg) if they feel the need.
I think it's a discussion we should have before merging this @montanaflynn @thefosk.