hotfix(migrations): set default for anonymous with auth plugins #2266
Conversation
|
This adds a new migration, which could possibly break a running cluster, therefore needs to be merged against |
We now avoid reading all request headers via `ngx.req.get_headers()` and use the `ngx.var` API instead. In the future, we'll distinguish Host fetching and full headers fetching when arbitrary headers matching will be added to the router.
When we don't route an API via its `hosts` property (no Host recorded), this test ensures that we still forward the incoming request `Host` header when `preserve_host = true`.
…out-hosts tests(router) ensure preserve_host without hosts matching
perf(router) efficient host header reading
|
@thefosk any way to make an exception here, given that a). this migration is very straightforward, and b). there are issues on 0.10.1 that this will fix? (#2293) |
|
@p0pr0ck5 it depends. What if this operation fails: row.config.anonymous = ""
local _, err = dao.plugins:update(row, { id = row.id })and we have 50% of plugins updated, and the other 50% not updated. How will this affect the cluster? In my opinion migrations shouldn't be pushed in minor releases. |
ngx.time uses a cached time struct that obviates the need for the syscall performed by os.time. additionally, os.time is not JITable.
perf(aws-lambda) use ngx.time in place of os.time
Support user directive of Nginx. From #2180
Signed-off-by: Wei.ZHAO <zhaowei@qiyi.com>
fix(test) remove the redundant right parentheses
In this case, it doesn't matter, you can run the migration again. That said, a migration takes a different upgrade approach, hence I'm with @thefosk that it should not be in a minor release. |
So should we update this PR to target |
+1 |
Tieske
force-pushed
the
fix/authmigration
branch
from
d64e6c4 to
f361737
Compare
The default value for
anonymous == "", yet the migrations were missingfixes #2264 but for all auth plugins.