-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(*) bump or compat vers #3070
Conversation
The CLI `quit` command would even on a forceful exit still print a 'graceful shutdown' message. From #3061
@thibaultcha are we missing anything here in a version bump? |
@p0pr0ck5 I don't think so, except purging the Travis cache if not done already, and maybe a somewhat clearer commit message for archeology purposes (say, containing "OpenResty" for the pickaxe tool). |
I think a good reference is to look at previous commit and following the same message structure: 9ac6be5 |
ed18eb3
to
dabb624
Compare
Nice, thanks for the refs! Travis is indeed "purged" (e.g., not available via cache) because of the vers. difference. We can see this empirically via Travis logs. I've adjust the commit msg as per the referenced commit above. Thanks! |
Oops, my bad - I think an OpenResty bump should go into next only! |
If we change the base branch to next, then the approval stands! :) |
Dang it! And I thought I got this right the first time ;) Okay, merging into |
No description provided.