[fix/api] Prevent PATCH from overriding plugin's value #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since plugin_configuration's `value` is stored as plain text in Cassandra, if one made a PATCH request it could potentially override the stored value because the DAO treated the field just like any other. Instead, we need to set each property of a `value` that is not updated by the PATCH before updating the row. That behaviour doesn't apply to PUT requests.
thibaultcha
changed the title
thibaultcha
added
the
pr/ready (but hold merge)
thibaultcha
added a commit
that referenced
this pull request
Jun 26, 2015
[fix/api] Prevent PATCH from overriding plugin's value
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
[fix/api] Prevent PATCH from overriding plugin's value Former-commit-id: 1336337dd2b860f54de408fe04d6454032eadf55
hutchic
added a commit
that referenced
this pull request
Jun 10, 2022
fix(image) fix typo in label name Co-authored-by: Colin Hutchinson <hutchic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#362 bis. Since plugin_configuration's
valueis stored as plain text inCassandra, if one made a PATCH request it could potentially override the
stored value because the DAO treated the field just like any other.
Instead, we need to set each property of a
valuethat is not updatedby the PATCH before updating the row.
That behaviour doesn't apply to PUT requests.