feat(proxy/pdk) add support for X-Forwarded-Prefix #5620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
feat/x-forwarded-prefix
branch
from
9439dc8 to
4bb8686
Compare
bungle
force-pushed
the
feat/x-forwarded-prefix
branch
from
4bb8686 to
29a0efa
Compare
You are right, but Github also has ignore whitespace when reviewing: |
kikito
requested changes
Feb 28, 2020
bungle
force-pushed
the
feat/x-forwarded-prefix
branch
from
29a0efa to
eefeefc
Compare
erikgb
reviewed
Feb 28, 2020
bungle
force-pushed
the
feat/x-forwarded-prefix
branch
from
eefeefc to
f258542
Compare
|
Anything more I can do to get this merged? I have reviewed the code, and I think it looks good. @kikito has requested changes, but I am not sure what changes are actually required. |
### Summary Kong currently adds these headers to upstream request: ``` X-Forwarded-For X-Forwarded-Port X-Forwarded-Proto X-Forwarded-Host X-Real-IP ``` @erikgb mentioned that he would like to have `X-Forwarded-Prefix` added on #5602. This PR adds that, and additionally introduces a new PDK function: ```lua local path = kong.request.get_forwarded_path() ``` ### Issues Resolved Close #5602
bungle
force-pushed
the
feat/x-forwarded-prefix
branch
from
f258542 to
2f54327
Compare
kikito
approved these changes
Mar 11, 2020
bungle
added a commit
that referenced
this pull request
Aug 7, 2020
### Summary The PR #5620 implemented `X-Forwarded-Prefix` wrong. The implementation looks more like proprietary `X-Forwarded-Path`. This commit changes that accordingly. Next commit in this PR will re-introduce X-Forwarded-Prefix correctly. I decided to keep the current behavior as it is already used in some code with PDK `kong.request.get_forwarded_path` (e.g. if the plugin needs to get the original request path, the one that is perhaps rewritten by Kong or a proxy before Kong, perhaps Kong as well).
bungle
added a commit
that referenced
this pull request
Aug 7, 2020
…warded_prefix ### Summary The PR #5620 implemented `X-Forwarded-Prefix` wrong as reported in these: - #6190 - Kong/kubernetes-ingress-controller#784 - #6132 And also by some other sources. This commit re-implements `X-Forwarded-Prefix`: 1. Is there trusted `X-Forwarded-Prefix` header in request? If yes, then set that as the `X-Forwarded-Prefix` (note: at this point we don't support multi-value `X-Forwarded-Prefix` headers, e.g. appending. We don't support multi-value in `X-Forwarded-Host/-Port/-Proto` either. 2. Has Kong router stripped the prefix of the request URI before proxying, if yes, then set `X-Forwarded-Prefix` to match the stripped prefix. 3. If 1 or 2 didn't set the header, set it to `/`. ### Issues Resolved Fix #6190 Fix Kong/kubernetes-ingress-controller#784 Fix #6132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Kong currently adds these headers to upstream request:
@erikgb mentioned that he would like to have
X-Forwarded-Prefixadded on #5602.
This PR adds that, and additionally introduces a new PDK function:
Issues Resolved
Close #5602