Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps) bump penlight from 1.7.0 to 1.9.2 #6194

Merged
merged 2 commits into from
Sep 27, 2020
Merged

Conversation

bungle
Copy link
Member

@bungle bungle commented Aug 6, 2020

Summary 1.8.0 -> 1.9.2

Fixes

Summary 1.7.0 -> 1.8.0

New features

  • pretty.debug quickly dumps a set of values to stdout for debug purposes

Changes

  • pretty.write: now also sorts non-string keys #319
  • stringx.count has an extra option to allow overlapping matches #326
  • added an extra changelog entry for types.is_empty on the 1.6.0 changelog, due to additional fixed behaviour not called out appropriately #313
  • path.packagepath now returns a proper error message with names tried if it fails

Fixes

  • Fix: stringx.rfind now properly works with overlapping matches #314
  • Fix: package.searchpath (in module pl.compat) #328
  • Fix: path.isabs now reports drive + relative-path as false, eg. "c:some/path" (Windows only)
  • Fix: OpenResty coroutines, used by dir.dirtree, pl.lexer, pl.permute. If available the original coroutine functions are now used #329
  • Fix: in pl.strict also predefine global _PROMPT2
  • Fix: in pl.strict apply tostring to the given name, in case it is not a string.
  • Fix: the lexer would not recognize numbers without leading zero; "-.123", see #315

@dndx
Copy link
Member

dndx commented Aug 12, 2020

Pending OpenResty assertion failure investigations by @bungle and @Tieske.

@Tieske
Copy link
Member

Tieske commented Aug 23, 2020

@bungle @dndx I reproduced the problem with penlight, see lunarmodules/Penlight#335 (comment)

Looks like an openresty bug to me, would you mind having a look @dndx ?

@Tieske Tieske force-pushed the chore/penlight-1.8.0 branch from e25d3c4 to ccaba07 Compare September 22, 2020 14:14
@Tieske
Copy link
Member

Tieske commented Sep 22, 2020

Added a new commit, bumping onwards to 1.9.0 (and rebased to fix conflicts)

Updated the initial description to include the changes of the 1.9.0 release

@Tieske Tieske changed the title chore(deps) bump penlight from 1.7.0 to 1.8.0 chore(deps) bump penlight from 1.7.0 to 1.9.0 Sep 22, 2020
@Tieske
Copy link
Member

Tieske commented Sep 22, 2020

seems Travis is failing on a crashing LuaJIT??
https://travis-ci.org/github/Kong/kong/jobs/729319326#L5840

@bungle bungle force-pushed the chore/penlight-1.8.0 branch from ccaba07 to 744af1f Compare September 23, 2020 07:09
@Tieske Tieske force-pushed the chore/penlight-1.8.0 branch from 744af1f to 1292641 Compare September 24, 2020 11:47
@Tieske Tieske changed the title chore(deps) bump penlight from 1.7.0 to 1.9.0 chore(deps) bump penlight from 1.7.0 to 1.8.1 Sep 24, 2020
### Summary

#### New features

  - `pretty.debug` quickly dumps a set of values to stdout for debug purposes

#### Changes

  - `pretty.write`: now also sorts non-string keys [#319](lunarmodules/Penlight#319)
  - `stringx.count` has an extra option to allow overlapping matches
    [#326](lunarmodules/Penlight#326)
  - added an extra changelog entry for `types.is_empty` on the 1.6.0 changelog, due
    to additional fixed behaviour not called out appropriately [#313](lunarmodules/Penlight#313)
  - `path.packagepath` now returns a proper error message with names tried if
    it fails

#### Fixes

  - Fix: `stringx.rfind` now properly works with overlapping matches
    [#314](lunarmodules/Penlight#314)
  - Fix: `package.searchpath` (in module `pl.compat`)
    [#328](lunarmodules/Penlight#328)
  - Fix: `path.isabs` now reports drive + relative-path as `false`, eg. "c:some/path" (Windows only)
  - Fix: OpenResty coroutines, used by `dir.dirtree`, `pl.lexer`, `pl.permute`. If
    available the original coroutine functions are now used [#329](lunarmodules/Penlight#329)
  - Fix: in `pl.strict` also predefine global `_PROMPT2`
  - Fix: in `pl.strict` apply `tostring` to the given name, in case it is not a string.
  - Fix: the lexer would not recognize numbers without leading zero; "-.123".
    See [#315](lunarmodules/Penlight#315)
Fixes

    In pl.class, _init can now be inherited from grandparent (or older ancestor) classes. #289
    Fixes dir, lexer, and permute to no longer use coroutines. #344
@Tieske Tieske force-pushed the chore/penlight-1.8.0 branch from db88af2 to 0d2ef58 Compare September 27, 2020 10:50
@Tieske Tieske changed the title chore(deps) bump penlight from 1.7.0 to 1.8.1 chore(deps) bump penlight from 1.7.0 to 1.9.2 Sep 27, 2020
@bungle bungle merged commit cce87dd into next Sep 27, 2020
@bungle bungle deleted the chore/penlight-1.8.0 branch September 27, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants