-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(balancer) remove old host when deleting target #7045
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting target, the old host should be removed. Instead of forcibly recreating a balancer. Fix Kong#6983
When deleting target, the old host should be removed. Instead of forcibly recreating a balancer. Fix Kong#6983
@fffonion please review this change. |
As #6983 turned out to be a documentation issue, and is now closed, this seems unrelated. @GoneGo1ng, please add further info. Thanks! |
@gszr Sorry, I replied too late. This is my upstream details.
Then, I updated "http_path".
Something strange happened. When I update http_path, the old http_path is still being requested. So I created this PR to solve this issue.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting target, the old host should be removed. Instead of forcibly recreating a balancer.
Fix #6983