feat: introduce DaoError for cleaner error report. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaoError is an error with a type and a message, just like the old table returned by base_dao.build_error() but it can be printed and concatenated in a string. Instead of printing err.message, it can be printed by just 'err'. This eliminates confusion when interacting with the DAO and the errors it returns and also allows the Factory to use those, unlike before (before, it was only returning errors from the cassandra drivers, as simple strings)
bungle
added a commit
that referenced
this pull request
Oct 19, 2022
### Summary ### [0.8.13] - 2022-10-14 #### bug fixes - **x509.\*:** fix set_extension will fail when a extension with same NID is not exist yet ([#75](fffonion/lua-resty-openssl#75)) [b2f57b8](fffonion/lua-resty-openssl@b2f57b8) #### features - **x509.altname:** support set and get IP addresses ([#74](fffonion/lua-resty-openssl#74)) [363c80d](fffonion/lua-resty-openssl@363c80d) - **x509.store:** add set_flags ([#77](fffonion/lua-resty-openssl#77)) [8f3f16a](fffonion/lua-resty-openssl@8f3f16a) ### [0.8.11] - 2022-10-12 #### performance improvements - **\*:** reuse cdata to improve performance [fc9cecd](fffonion/lua-resty-openssl@fc9cecd)
bungle
added a commit
that referenced
this pull request
Oct 19, 2022
### Summary ### [0.8.13] - 2022-10-14 #### bug fixes - **x509.\*:** fix set_extension will fail when a extension with same NID is not exist yet ([#75](fffonion/lua-resty-openssl#75)) [b2f57b8](fffonion/lua-resty-openssl@b2f57b8) #### features - **x509.altname:** support set and get IP addresses ([#74](fffonion/lua-resty-openssl#74)) [363c80d](fffonion/lua-resty-openssl@363c80d) - **x509.store:** add set_flags ([#77](fffonion/lua-resty-openssl#77)) [8f3f16a](fffonion/lua-resty-openssl@8f3f16a) ### [0.8.11] - 2022-10-12 #### performance improvements - **\*:** reuse cdata to improve performance [fc9cecd](fffonion/lua-resty-openssl@fc9cecd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DaoError is an error with a type and a message, just like the old table returned by
base_dao.build_error()but it can be printed and concatenated in a string.Instead of printing err.message, it can be printed by just 'err'. This eliminates confusion when interacting with the DAO and the errors it returns and also allows the Factory to use those, unlike before (before, it was only returning errors from the cassandra driver, as simple strings)