fix(balancers) stop health check when recreating balancer #7549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks reasonable. is it better than how it was done on #7408? (it was on target events, here it is on balancer recreation) |
javierguerragiraldez
approved these changes
Jul 21, 2021
|
The only reason for moving this change to the balancer recreation is that the balancer controls the health checker, and targets don't. Essentially both changes will do the same. |
locao
force-pushed
the
fix/stop_hc_on_tgt_event
branch
from
fcd58b0
to
692c44f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7408, balancer code has been rewritten after that PR was merged.