fix(runloop) reschedule rebuild timers after running them #8634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a backport of #8567 that is merged into
master.Router and plugin iterator rebuild timers were scheduled using ngx.timer.every. If the rebuild processes took longer than worker_state_update_frequency to execute, they would start again while the previous one was still running.
Full changelog
Change ngx.timer.every calls to ngx.timer.at.
Previously returned error "plugins iterator was changed while rebuilding it" is now logged as an info message.
No tests were added, the behavior is the same as before.
Issue reference
There were multiple reports of "plugins iterator was changed while rebuilding it" logged as error.
Fix #8525
FTI-3239