feat(stream_api): use TCP instead of UDP #8641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flrgh
force-pushed
the
fix/stream-api-payload-size
branch
from
dfa9c5c
to
d9b18f3
Compare
This re-implements the stream API to use TCP instead of UDP in order to allow for larger response payloads. Keep-alive is used to cut down on per-request connection overhead.
flrgh
force-pushed
the
fix/stream-api-payload-size
branch
from
d9b18f3
to
bf8178e
Compare
javierguerragiraldez
approved these changes
Apr 6, 2022
fffonion
reviewed
Apr 6, 2022
|
@javierguerragiraldez @flrgh Can I merge the changes here into the 2.4.1 and 2.5.1 ? |
@zhangzerui20 sorry it's taken so long to get back to you on this thread! While there is nothing stopping you from opening up a PR for this, it's unlikely to be accepted, as these are very old branches that we are no longer actively maintaining. The last 2.5.x release was ~1.5 years ago, and the last 2.4.x release was 2 years ago. The only reason I could potentially see us cutting a new 2.4.x or 2.5.x release would be to backport a critical security fix or something of that level of priority. I think at this stage the effort would be better spent on getting infra upgraded to the 3.x series. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-implements the stream API with TCP instead of UDP in order to allow for larger response payloads without having to handle chunking/fragmenting things ourselves.
Performance-wise, keep-alive is used to cut down on per-request connection overhead, and the message payload is sent raw instead of being packed/unpacked on either side. I've done some unscientific testing locally with a single-threaded client and an API that simply echoes back the input payload. With a payload size of 8000 (the max of the current implementation) I am getting ~7-8k rps with the current implementation and ~8-9k rps with this new implementation. Things will obviously degrade from there with larger payload sizes, though I don't think I've raised the limit so high as to necessitate further optimizations (let me know if this is an incorrect assumption though).
Error-handling has also been reworked quite a bit, with many code paths that were previously throwing an exception (
error()) replaced with logging and/or returning the error to the caller.Fixes #7377