fix(zipkin) include connect time in balancer span #8848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayocream
force-pushed
the
fix/zipkin-balancer-time
branch
from
29e12d3
to
997c473
Compare
mayocream
force-pushed
the
fix/zipkin-balancer-time
branch
from
997c473
to
449d3c1
Compare
gszr
approved these changes
May 25, 2022
|
I'll revisit this later; we should make it the same behavior as the tracing pdk build-in instrumentation (in this case, only for balancer spans). |
kikito
approved these changes
May 26, 2022
|
I have approved this, but please include a |
mayocream
force-pushed
the
fix/zipkin-balancer-time
branch
from
449d3c1
to
1ea14ef
Compare
mayocream
force-pushed
the
fix/zipkin-balancer-time
branch
from
f461ad4
to
c7391bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
include connect time in balancer span