feat(router) new router support and tests fix #8938
Conversation
| local router = setmetatable({ | ||
| schema = s, | ||
| router = inst, | ||
| routes = {}, |
There was a problem hiding this comment.
Could we use table.new to pre-allocate table?
dndx
force-pushed
the
feat/new_router
branch
13 times, most recently
from
515515d
to
f4869a0
Compare
.requirements
Outdated
| @@ -9,5 +9,5 @@ RESTY_PCRE_VERSION=8.45 | |||
| RESTY_LMDB_VERSION=master | |||
| RESTY_EVENTS_VERSION=0.1.1 | |||
| LIBYAML_VERSION=0.2.5 | |||
| KONG_BUILD_TOOLS_VERSION=4.30.0 | |||
| KONG_BUILD_TOOLS_VERSION=feat/atc_router_build | |||
There was a problem hiding this comment.
change it to official version before merge
There was a problem hiding this comment.
I think this could be 4.32.3 or 4.33.
|
|
||
|
|
||
| local function is_regex_magic(path) | ||
| return sub(path, 1, 1) == "~" |
There was a problem hiding this comment.
It may be replaced with OP_REGEX below?
github-actions
bot
removed
the
chore
github-actions
bot
added
the
chore
github-actions
bot
removed
the
chore
There was a problem hiding this comment.
We need to add ATC to .requirement.
Also, we need to add libatc_router.so to dyn lib search path (cpath).
Update: It's my local build's problem. I manually installed the ATC library on the wrong path.
And, maybe we need to update developer.md about passing ATC's version to build script.
|
We aslo need to add an entry in |
|
|
||
| local c = context.new(self.schema) | ||
|
|
||
| for _, field in ipairs(self.fields) do |
There was a problem hiding this comment.
it seems headers are the only variables that we fetch lazily. Could we just unconditionally add all other fields here?
Most tests working, still fixing a few leftover ones