perf(clustering) no concurrent inflating and json decoding on dps #8959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
perf/clustering-concurrency
branch
from
29e1e70
to
2390454
Compare
### Summary Previously it could be that `read_thread` caused concurrent blocking when inflating / json decoding incoming data. This commit moves it beyond the semaphore to make it non-concurrent.
bungle
force-pushed
the
perf/clustering-concurrency
branch
from
2390454
to
e4470a0
Compare
flrgh
reviewed
Jun 15, 2022
flrgh
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously it could be that
read_threadcaused concurrent blocking when inflating / json decoding incoming data. This commit moves it beyond the semaphore to make it non-concurrent.