Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core) allow spaces to be used in tag names FT-2680 #9143

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

hanshuebner
Copy link
Contributor

Summary

This change updates Kong so that space characters can be used in tag
names. The tags related tests have been updated to use tag names with
spaces.

kong/api/endpoints.lua Outdated Show resolved Hide resolved
spec/02-integration/04-admin_api/14-tags_spec.lua Outdated Show resolved Hide resolved
spec/02-integration/03-db/07-tags_spec.lua Outdated Show resolved Hide resolved
spec/02-integration/04-admin_api/14-tags_spec.lua Outdated Show resolved Hide resolved
@hanshuebner hanshuebner force-pushed the FT-2680-space-in-tags branch 2 times, most recently from 67e9959 to dc7a0cf Compare July 28, 2022 13:22
kong/api/endpoints.lua Show resolved Hide resolved
@hanshuebner hanshuebner force-pushed the FT-2680-space-in-tags branch 2 times, most recently from c763eff to dac5dc0 Compare August 9, 2022 15:32
This change updates Kong so that space characters can be used in tag
names.  The tags related tests have been updated to use tag names with
spaces.
Copy link
Contributor

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kikito kikito merged commit 06908a1 into master Aug 10, 2022
@kikito kikito deleted the FT-2680-space-in-tags branch August 10, 2022 17:18
hanshuebner pushed a commit that referenced this pull request Aug 18, 2022
hanshuebner added a commit that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants