Reducing avg Serf UDP packet sizes #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subnetmarco
force-pushed
the
chore/serf-packet-size
branch
4 times, most recently
from
c707c3b to
fae2374
Compare
subnetmarco
force-pushed
the
chore/serf-packet-size
branch
from
fae2374 to
41f3448
Compare
subnetmarco
added
the
pr/ready (but hold merge)
subnetmarco
added a commit
that referenced
this pull request
Feb 9, 2016
Reducing avg Serf UDP packet sizes
|
I noticed the docs not being in line with serf docs. Serf has a hard limit of 512 bytes for a custom event. The Kong docs mention 64kb. |
|
@Tieske good catch - we need to update the docs. And also we need to document the change introduced by this PR. |
|
and streamline the clustering docs. |
|
I have updated the website with the new size limit of 512 bytes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
marshall_eventby default now returns an empty object, and the properties to propagate need to be explicitly returned.This changed the previous behavior where by default
marshall_eventreturned the entire object.As a result, the average packet size being exchanged by Serf is reduced.