Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(utils): use kong.utils.table_merge implementation to replace kong.table.merge #9857

Merged
merged 2 commits into from
Mar 7, 2023
Merged

refactor(utils): use kong.utils.table_merge implementation to replace kong.table.merge #9857

merged 2 commits into from
Mar 7, 2023

Conversation

vm-001
Copy link
Contributor

@vm-001 vm-001 commented Dec 2, 2022 •
edited
Loading

Summary

According to the PR #3844, using kong.utils.table_merge in plugin is not recommended anymore. And the table merge function of kong.table is more efficient than the deprecated one, as it does not create an empty table if it's nil.

Checklist

  • The Pull Request has tests
  • There's an entry in the CHANGELOG (Probably don't need to update CHANGELOG as it doesn't fix anything? )
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

@vm-001 vm-001 force-pushed the chore/convert-deprecated-function branch 2 times, most recently from 37d7da1 to fddbe7a Compare December 2, 2022 06:19
@vm-001 vm-001 marked this pull request as ready for review December 2, 2022 06:19
@vm-001 vm-001 force-pushed the chore/convert-deprecated-function branch 2 times, most recently from b8afcc4 to 351126b Compare December 2, 2022 06:31
@vm-001 vm-001 changed the title chore(*): use kong.table.merge chore(*): use kong.table.merge implementation to replace kong.utils.table_merge Dec 2, 2022
mayocream
mayocream reviewed Dec 6, 2022
View reviewed changes
kong/tools/utils.lua Outdated Show resolved Hide resolved
mayocream
mayocream previously requested changes Dec 7, 2022
View reviewed changes
spec/01-unit/26-tracing/02-propagation_spec.lua Outdated Show resolved Hide resolved
@flrgh flrgh requested a review from mayocream December 8, 2022 23:54
@flrgh flrgh dismissed mayocream’s stale review December 8, 2022 23:54

author made the requested change(s)

@vm-001 vm-001 changed the title chore(*): use kong.table.merge implementation to replace kong.utils.table_merge chore(*): use kong.utils.table_merge implementation to replace kong.table.merge Dec 16, 2022
mayocream
mayocream reviewed Dec 16, 2022
View reviewed changes
kong/db/dao/init.lua Outdated Show resolved Hide resolved
kong/pdk/table.lua Outdated Show resolved Hide resolved
kong/db/dao/init.lua Outdated Show resolved Hide resolved
spec/03-plugins/37-opentelemetry/05-otelcol_spec.lua Outdated Show resolved Hide resolved
@hbagdi
Copy link
Member

hbagdi commented Dec 20, 2022

The right commit type for this change is refactor: https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#type

@dndx
Copy link
Member

dndx commented Dec 27, 2022

Ping @vm-001

@dndx dndx added the pending author feedback Waiting for the issue author to get back to a maintainer with findings, more details, etc... label Jan 9, 2023
@stale
Copy link

stale bot commented Feb 14, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 14, 2023
@vm-001 vm-001 force-pushed the chore/convert-deprecated-function branch from 0318c35 to 54def3b Compare February 21, 2023 10:13
@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 21, 2023
@stale stale bot removed the stale label Feb 21, 2023
@vm-001 vm-001 force-pushed the chore/convert-deprecated-function branch from 54def3b to b08d4a3 Compare February 21, 2023 10:16
@github-actions github-actions bot added build/bazel chore Not part of the core functionality of kong, but still needed labels Feb 21, 2023
@vm-001 vm-001 force-pushed the chore/convert-deprecated-function branch from b08d4a3 to 4d70355 Compare February 21, 2023 10:19
@pull-request-size pull-request-size bot added size/M and removed size/L labels Feb 21, 2023
@github-actions github-actions bot removed build/bazel chore Not part of the core functionality of kong, but still needed labels Feb 21, 2023
@vm-001 vm-001 force-pushed the chore/convert-deprecated-function branch from 4d70355 to 4565120 Compare February 21, 2023 10:22
@vm-001 vm-001 force-pushed the chore/convert-deprecated-function branch from 4565120 to 23e709c Compare February 21, 2023 10:25
@vm-001 vm-001 changed the title chore(*): use kong.utils.table_merge implementation to replace kong.table.merge refactor(*): use kong.utils.table_merge implementation to replace kong.table.merge Feb 21, 2023
@vm-001 vm-001 changed the title refactor(*): use kong.utils.table_merge implementation to replace kong.table.merge refactor(utils): use kong.utils.table_merge implementation to replace kong.table.merge Feb 21, 2023
@dndx dndx removed the pending author feedback Waiting for the issue author to get back to a maintainer with findings, more details, etc... label Mar 1, 2023
@dndx
Copy link
Member

dndx commented Mar 1, 2023

@vm-001 Can I bother you to rebase this again? I want to get this merged soon.

@vm-001
Copy link
Contributor Author

vm-001 commented Mar 2, 2023

@dndx Done

@hanshuebner hanshuebner merged commit 68a423a into master Mar 7, 2023
@hanshuebner hanshuebner deleted the chore/convert-deprecated-function branch March 7, 2023 11:15
oowl pushed a commit that referenced this pull request Aug 15, 2024
@catbro666
feat(jwt-signer): supported /jwt-signer/jwks/:jwt_signer_jwks endpo…
ed888d1 
…int in dbless mode (#9857)

Currently in dbless mode it's unable to get keyset created by Kong which would be
used to validate the token resigned by jwt-signer plugin.

This PR extends `/jwt-signer/jwks/:jwt_signer_jwks` endpoint to support dbless.

Fix FTI-5718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayocream mayocream mayocream left review comments

@flrgh flrgh flrgh left review comments

@samugi samugi samugi approved these changes

Assignees

@vm-001 vm-001

Labels
core/db core/pdk plugins/opentelemetry size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vm-001 @hbagdi @dndx @flrgh @samugi @mayocream @hanshuebner