Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integration): re-enable some tests by renaming their filename #9906

Merged
merged 7 commits into from
Dec 13, 2022

Conversation

windmgc
Copy link
Member

@windmgc windmgc commented Dec 7, 2022

Summary

It seems some of the test files are not ending with a _spec suffix in their file names.
Thus maybe they're not tested for a long time...

Checklist

Full changelog

  • re-enable some tests by renaming their filename

@windmgc
Copy link
Member Author

windmgc commented Dec 7, 2022

Rename the following spec files as they seem useful:

  • spec/01-unit/19-hybrid/04-negotiation_spec.lua
  • spec/02-integration/04-admin_api/12-plugins-conf_spec.lua
  • spec/02-integration/09-hybrid_mode/08-lazy_export_spec.lua
  • spec/02-integration/11-dbless/03-config_persistence_spec.lua
  • spec/03-plugins/26-prometheus/06-hybrid-mode_metrics_spec.lua

Delete one spec file as it seems deprecated

  • spec/02-integration/04-admin_api/18-worker-events.lua (There was an age when worker-events is a plugin? interesting)

@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Dec 7, 2022
@windmgc
Copy link
Member Author

windmgc commented Dec 7, 2022

Add an action step in Lint, Doc and Unit tests to check spec files spelling.

Check for a preview result here: https://github.com/Kong/kong/actions/runs/3640543353/jobs/6145358948

@flrgh
Copy link
Contributor

flrgh commented Dec 9, 2022

(There was an age when worker-events is a plugin? interesting)

Fun fact: it's actually a test fixture that is still around. Nifty way of testing internal features by throwing them in a dummy plugin handler.

Copy link
Contributor

@flrgh flrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm, always appreciate more tests :)

@flrgh
Copy link
Contributor

flrgh commented Dec 9, 2022

Not merging quite this moment because CI is currently ❌ for master, but as far as I'm concerned it's good to merge once that is taken care of.

@fffonion fffonion merged commit 2b8d444 into master Dec 13, 2022
@fffonion fffonion deleted the test-re-enable-test branch December 13, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not part of the core functionality of kong, but still needed size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants