-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(integration): re-enable some tests by renaming their filename #9906
Conversation
Rename the following spec files as they seem useful:
Delete one spec file as it seems deprecated
|
Add an action step in Check for a preview result here: https://github.com/Kong/kong/actions/runs/3640543353/jobs/6145358948 |
Fun fact: it's actually a test fixture that is still around. Nifty way of testing internal features by throwing them in a dummy plugin handler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 lgtm, always appreciate more tests :)
Not merging quite this moment because CI is currently ❌ for |
Co-authored-by: Michael Martin <flrgh@protonmail.com>
5cabb11
to
6059ea0
Compare
Summary
It seems some of the test files are not ending with a
_spec
suffix in their file names.Thus maybe they're not tested for a long time...
Checklist
Full changelog