Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kbutton): remove deprecated icon slot #2215

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix(kbutton): remove deprecated icon slot #2215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 39 additions & 42 deletions sandbox/pages/SandboxButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,87 +411,84 @@
/>
<SandboxSectionComponent>
<div class="horizontal-spacing">
<KButton size="large">
<template #icon>
<AddCircleIcon />
</template>
<KButton
icon
size="large"
>
<AddCircleIcon />
</KButton>
<KButton
appearance="secondary"
icon
size="large"
>
<template #icon>
<ProfileIcon />
</template>
<ProfileIcon />
</KButton>
<KButton
appearance="tertiary"
icon
size="large"
>
<template #icon>
<BookIcon />
</template>
<BookIcon />
</KButton>
<KButton
appearance="danger"
icon
size="large"
>
<template #icon>
<DisabledIcon />
</template>
<DisabledIcon />
</KButton>
</div>
<div class="horizontal-spacing">
<KButton>
<template #icon>
<AddCircleIcon />
</template>
<KButton icon>
<AddCircleIcon />
</KButton>
<KButton appearance="secondary">
<template #icon>
<ProfileIcon />
</template>
<KButton
appearance="secondary"
icon
>
<ProfileIcon />
</KButton>
<KButton appearance="tertiary">
<template #icon>
<BookIcon />
</template>
<KButton
appearance="tertiary"
icon
>
<BookIcon />
</KButton>
<KButton appearance="danger">
<template #icon>
<DisabledIcon />
</template>
<KButton
appearance="danger"
icon
>
<DisabledIcon />
</KButton>
</div>
<div class="horizontal-spacing">
<KButton size="small">
<template #icon>
<AddCircleIcon />
</template>
<KButton
icon
size="small"
>
<AddCircleIcon />
</KButton>
<KButton
appearance="secondary"
icon
size="small"
>
<template #icon>
<ProfileIcon />
</template>
<ProfileIcon />
</KButton>
<KButton
appearance="tertiary"
icon
size="small"
>
<template #icon>
<BookIcon />
</template>
<BookIcon />
</KButton>
<KButton
appearance="danger"
icon
size="small"
>
<template #icon>
<DisabledIcon />
</template>
<DisabledIcon />
</KButton>
</div>
</SandboxSectionComponent>
Expand Down
9 changes: 5 additions & 4 deletions sandbox/pages/SandboxCatalog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,11 @@
Card title
</template>
<template #card-actions>
<KButton size="small">
<template #icon>
<KongIcon />
</template>
<KButton
icon
size="small"
>
<KongIcon />
</KButton>
</template>
<template #card-body>
Expand Down
5 changes: 2 additions & 3 deletions sandbox/pages/SandboxTable/SandboxTableActions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@
<template #default>
<KButton
appearance="tertiary"
icon
size="small"
>
<template #icon>
<MoreIcon />
</template>
<MoreIcon />
</KButton>
</template>
<template #items>
Expand Down
5 changes: 2 additions & 3 deletions src/components/KTable/ColumnVisibilityMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,10 @@
aria-label="Show/Hide Columns"
class="menu-button"
data-testid="column-visibility-menu-button"
icon
size="large"
>
<template #icon>
<TableColumnsIcon decorative />
</template>
<TableColumnsIcon decorative />
</KButton>
</KTooltip>

Expand Down
Loading