fix(analytics): only show metric cards if apps are present [MA-3030] #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateslo
reviewed
Aug 1, 2024
| @@ -39,7 +39,10 @@ | |||
| class="no-auth-strategies-warning" | |||
| data-testid="no-auth-strategies-warning" | |||
| /> | |||
| <AnalyticsConfigCheck require-analytics> | |||
| <AnalyticsConfigCheck | |||
| v-if="!myAppsReady || appsArePresent" | |||
There was a problem hiding this comment.
!myAppsReady is the "not" intended here?
There was a problem hiding this comment.
Yes, the logic is:
- Apps are loading ->
myAppsReadyisfalse-> show the skeleton loader for the metric cards. - If apps are present ->
appsArePresentistrue-> show the metric cards and let them issue the query. - If apps are not present ->
appsArePresentisfalse-> hide the metric cards.
I tested without !myAppsReady and the UX seemed jarring -- the metric cards would pop up as soon the table loaded and cause the table to shift downward. It seems less jarring to hide them when the apps are not present.
nateslo
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.