Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Konnect): add fields for adopting existing konnect entities #250

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

randmonkey
Copy link
Contributor

What this PR does / why we need it:
Adds spec.konnect.adopt.id for adopting an existing entity. This PR adds the spec and validation rules for KongService and KonnectGatewayControlPlane.
Which issue this PR fixes

Part of #232

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@randmonkey randmonkey requested a review from a team as a code owner January 22, 2025 10:12
@randmonkey randmonkey marked this pull request as draft January 22, 2025 10:12
@randmonkey randmonkey self-assigned this Jan 23, 2025
@randmonkey randmonkey added this to the KGO v1.5.x milestone Jan 23, 2025
@randmonkey randmonkey force-pushed the feat/spec_konnect_entityid branch 2 times, most recently from 128c0a6 to 33df9ea Compare January 23, 2025 09:36
@randmonkey randmonkey marked this pull request as ready for review January 24, 2025 07:37
@randmonkey randmonkey force-pushed the feat/spec_konnect_entityid branch from 33df9ea to 415d370 Compare January 24, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant