Skip to content

Commit

Permalink
Replace hardcoding with defined variables.
Browse files Browse the repository at this point in the history
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
  • Loading branch information
tao12345666333 committed Apr 17, 2024
1 parent 8de5e47 commit 059960f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/conformance/gateway_conformance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ var traditionalRoutesSupportedFeatures = []suite.SupportedFeature{
suite.SupportHTTPRoute,
// extended features
suite.SupportHTTPRouteResponseHeaderModification,
// TODO: https://github.com/Kong/kubernetes-ingress-controller/issues/5868
// Temporarily disabled and tracking through the following issue.
// https://github.com/Kong/kubernetes-ingress-controller/issues/5868
// suite.SupportHTTPRouteBackendTimeout,
}

Expand All @@ -44,8 +44,8 @@ var expressionRoutesSupportedFeatures = []suite.SupportedFeature{
suite.SupportHTTPRouteQueryParamMatching,
suite.SupportHTTPRouteMethodMatching,
suite.SupportHTTPRouteResponseHeaderModification,
// TODO: https://github.com/Kong/kubernetes-ingress-controller/issues/5868
// Temporarily disabled and tracking through the following issue.
// https://github.com/Kong/kubernetes-ingress-controller/issues/5868
// suite.SupportHTTPRouteBackendTimeout,
}

Expand All @@ -63,10 +63,10 @@ func TestGatewayConformance(t *testing.T) {
case dpconf.RouterFlavorTraditionalCompatible:
skippedTests = skippedTestsForTraditionalRoutes
supportedFeatures = traditionalRoutesSupportedFeatures
mode = "traditional-compatible"
mode = string(dpconf.RouterFlavorTraditionalCompatible)
case dpconf.RouterFlavorExpressions:
supportedFeatures = expressionRoutesSupportedFeatures
mode = "expressions"
mode = string(dpconf.RouterFlavorExpressions)
default:
t.Fatalf("unsupported KongRouterFlavor: %s", rf)
}
Expand Down

0 comments on commit 059960f

Please sign in to comment.